Skip to content
Snippets Groups Projects
Commit 22f634cc authored by Florian Bruhin's avatar Florian Bruhin
Browse files

Fix test selector crash

Fixes #12
parent 833de6c7
No related branches found
No related tags found
No related merge requests found
......@@ -15,9 +15,11 @@ from traitlets.config.application import TRAITLETS_APPLICATION_RAISE_CONFIG_FILE
from commander.gui import utils
NodeIdRole = Qt.ItemDataRole.UserRole
class OverviewModel(QAbstractTableModel):
NodeIdRole = Qt.ItemDataRole.UserRole
COLUMNS = ["nodeid", "tag", "when", "outcome", "message"]
node_ids_loaded = pyqtSignal(list)
tag_mapping_loaded = pyqtSignal(dict)
......@@ -76,7 +78,7 @@ class OverviewModel(QAbstractTableModel):
if key == 'nodeid' and role == Qt.ItemDataRole.DisplayRole:
return self._data_nodeid(report, short=True)
elif key == 'nodeid' and role == self.NodeIdRole:
elif key == 'nodeid' and role == NodeIdRole:
return self._data_nodeid(report, short=False)
elif key == 'tag' and role == Qt.ItemDataRole.DisplayRole:
return self._data_tag(report)
......@@ -211,7 +213,7 @@ class OverviewView(QTableView):
index.parent(),
)
nodeid = self._filter_model.data(nodeid_index, self.overview_model.NodeIdRole)
nodeid = self._filter_model.data(nodeid_index, NodeIdRole)
assert nodeid
self.test_activated.emit(nodeid)
......@@ -231,8 +233,8 @@ class OverviewView(QTableView):
def on_test_changed(self, name: str) -> None:
idx = self.overview_model.find_by_short_nodeid(name)
self.selectRow(idx.row())
node_id = self._filter_model.data(idx, self._filter_model.NodeIdRole)
assert note_id
node_id = self.overview_model.data(idx, NodeIdRole)
assert node_id
self.test_activated.emit(node_id)
self.setFocus()
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment